Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the last bits of tracing-core #519

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Get the last bits of tracing-core #519

merged 3 commits into from
Jan 10, 2020

Conversation

yaahc
Copy link
Collaborator

@yaahc yaahc commented Jan 9, 2020

fixes #440

hawkw
hawkw reviewed Jan 9, 2020
View reviewed changes
tracing-core/src/dispatcher.rs Outdated Show resolved Hide resolved
tracing-core/src/dispatcher.rs Outdated Show resolved Hide resolved
tracing-core/src/dispatcher.rs Outdated Show resolved Hide resolved
hawkw
hawkw approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm going to merge this into my branch so we can get the tracing-core changes in & cut a release. will happily merge more PRs for adding doc_cfg to additional crates.

@hawkw hawkw merged commit 87e7f6a into tokio-rs:eliza/doc-cfg Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaahc @hawkw