Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] make Span::in_scope work with async blocks as well as closures #734

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[DRAFT] make Span::in_scope work with async blocks as well as closures #734

wants to merge 2 commits into from

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented May 24, 2020

This isn't quite done yet, and would need to wait until tracing 0.2 to release, but here's a rough sketch of a version of Span::in_scope that works transparently with async blocks or closures.

@hawkw
WIP draft of a more generic in_scope
763a296 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw hawkw requested a review from a team as a code owner May 24, 2020 18:36
@hawkw hawkw marked this pull request as draft May 24, 2020 18:36
@hawkw
whoops it needs to be public for it to work
85995a5 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@bryangarza
Copy link
Member

@hawkw is this something that can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky will be requested when the pull request is marked ready for review davidbarsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkw @bryangarza