-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rusty Days talk #876
Add Rusty Days talk #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks for adding your talk!
i have a slight preference for making the whitespace change in a separate commit... but it doesn’t bother me that much. it would matter a little more if this was a code change.
as a side note, i wonder if we should add the list of resources to the |
surprised ci is failing for this — maybe new warnings? |
Okay, we just merged PR #882 that should fix the CI failure. Mind rebasing onto that? |
e38a417
to
d22cd5a
Compare
Rebased 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good to me — thanks for adding it!
By the way, I watched your talk, and it's a great summary of the state of observability tooling in Rust. Nice job! :)
Thank you 😁 |
I spent quite a large portion of my talk at Rusty days discussing logging/structured logging/distributed tracing, covering our usage of
tracing
.If you think it's relevant I'd be happy to add it to the list 😁
P.S. there were some trailing whitespaces that my VIM setup ruthlessly eliminated. Let me know if you want me to leave them there.