Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rusty Days talk #876

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Add Rusty Days talk #876

merged 2 commits into from
Aug 5, 2020

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Aug 2, 2020

I spent quite a large portion of my talk at Rusty days discussing logging/structured logging/distributed tracing, covering our usage of tracing.
If you think it's relevant I'd be happy to add it to the list 😁

P.S. there were some trailing whitespaces that my VIM setup ruthlessly eliminated. Let me know if you want me to leave them there.

@LukeMathWalker LukeMathWalker requested review from hawkw and a team as code owners August 2, 2020 11:19
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks for adding your talk!

i have a slight preference for making the whitespace change in a separate commit... but it doesn’t bother me that much. it would matter a little more if this was a code change.

README.md Outdated Show resolved Hide resolved
@hawkw
Copy link
Member

hawkw commented Aug 2, 2020

as a side note, i wonder if we should add the list of resources to the tracing crate’s README and/or lib.rs docs, so it’s easier to find? cc @davidbarsky

@hawkw
Copy link
Member

hawkw commented Aug 2, 2020

surprised ci is failing for this — maybe new warnings?

@hawkw
Copy link
Member

hawkw commented Aug 3, 2020

Okay, we just merged PR #882 that should fix the CI failure. Mind rebasing onto that?

@LukeMathWalker
Copy link
Contributor Author

Rebased 👍

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me — thanks for adding it!

By the way, I watched your talk, and it's a great summary of the state of observability tooling in Rust. Nice job! :)

@hawkw hawkw merged commit c0964d9 into tokio-rs:master Aug 5, 2020
@LukeMathWalker
Copy link
Contributor Author

Thank you 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants