Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: Add semantic convention docs #877

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

jtescher
Copy link
Collaborator

@jtescher jtescher commented Aug 2, 2020

This branch adds crate-level docs for the otel trace semantic conventions and their usage as well as notes on stability status.

Resolves #747

@jtescher jtescher requested a review from a team as a code owner August 2, 2020 19:35
@hawkw
Copy link
Member

hawkw commented Aug 3, 2020

Sorry about the CI failures, that was unrelated. We just merged PR #882 that should fix it. Mind rebasing onto master?

This branch adds crate-level docs for the otel trace semantic
conventions and their usage as well as notes on stability status.
@jtescher jtescher force-pushed the jtescher/semantic-convention-docs branch from 9982de6 to 4ff77d7 Compare August 3, 2020 20:39
@jtescher
Copy link
Collaborator Author

jtescher commented Aug 3, 2020

@hawkw done 👍

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtescher jtescher merged commit 4b2e606 into master Aug 4, 2020
@jtescher jtescher deleted the jtescher/semantic-convention-docs branch August 4, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add opentelemetry attribute documetation
2 participants