Fix broken tracing documentation formatting #881
Conversation
There was a problem hiding this comment.
Thanks, this looks great to me.
The CI failure is not related; #882 should fix it. Mind rebasing when this is merged?
We should also do a quick check of the other warning boxes to make sure they don't have the same unclosed <div>.
It's a bummer that the netlify deploy preview doesn't catch this...probably you're right and it's closing a div that's docs.rs-specific.
|
Okay, we just merged PR #882 that should fix the CI failure. Mind rebasing onto that? |
|
This was probably because of rust-lang/docs.rs#930. Sorry it broke your docs - the reason it worked before is that we parsed the HTML from scratch instead of rewriting it, and so the parser could guess at the end tags. I don't really have ideas for testing this ... maybe you could run |
Thanks for letting us know, and no need to apologize...it's really our fault for having an unclosed tag in our docs (and for using custom HTML in the first place)... |
Fixed - Updated `tracing-core` to fix incorrect calculation of the global max level filter (#908) Added - **attributes**: Support for using `self` in field expressions when instrumenting `async-trait` functions (#875) - Several documentation improvements (#832, #881, #896, #897, #911, #913) Thanks to @anton-dutov, @nightmared, @mystor, and @toshokan for contributing to this release!
### Fixed - Updated `tracing-core` to fix incorrect calculation of the global max level filter (#908) ### Added - **attributes**: Support for using `self` in field expressions when instrumenting `async-trait` functions (#875) - Several documentation improvements (#832, #881, #896, #897, #911, #913) Thanks to @anton-dutov, @nightmared, @mystor, and @toshokan for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
I wasn't able to reproduce the exact formatting issues seen on docs.rs locally, though from some source inspection, this extra
</div>appears to be the culprit.(hopefully) fixes #880