Pull visibilty policy up #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcches
reviewed
Dec 11, 2023
src/sim.rs
Outdated
| @@ -34,7 +34,7 @@ pub struct Sim<'a> { | |||
| } | |||
|
|
|||
| impl<'a> Sim<'a> { | |||
| pub(crate) fn new(config: Config, world: World) -> Self { | |||
| pub fn new(config: Config, world: World) -> Self { | |||
There was a problem hiding this comment.
I don't believe this one should change. Construction should happen through the builder.
Before this commit, all visibility was handled at the lowest level possible. This litters the code with pub(crate) in almost every file. Instead, what my commit does is let the highest level possible deal with it.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, all visibility was handled at the lowest level possible. This litters the code with pub(crate) in almost every file. Instead, what my commit does is let the highest level possible deal with it.