Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade grpc example deps, fixing #180 #181

Merged

Conversation

LeonHartley
Copy link
Contributor

No description provided.

Copy link
Contributor

@mcches mcches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

}
}

impl tonic::transport::server::Connected for TurmoilTcpStream {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that TokioIo brings us pretty close to not having to implement all these traits for turmoil types, other than this one.

Copy link
Contributor Author

@LeonHartley LeonHartley Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the AsyncRead / AsyncWrite implementations, or implementations for hyper::rt::Read/Write as TokioIo<T> requires T to impl either of those

@mcches
Copy link
Contributor

mcches commented Aug 22, 2024

Can you check out the clippy failure?

@LeonHartley
Copy link
Contributor Author

LeonHartley commented Aug 23, 2024

@mcches doesn't look related to the changes to the gRPC example:

Checking turmoil v0.6.3 (/home/runner/work/turmoil/turmoil)
error: unexpected `cfg` condition name: `tokio_unstable`
   --> src/rt.rs:220:11
    |
220 |     #[cfg(tokio_unstable)]
    |           ^^^^^^^^^^^^^^
    |
    = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows`
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tokio_unstable)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tokio_unstable)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `-D unexpected-cfgs` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`

error: unexpected `cfg` condition name: `tokio_unstable`
   --> src/rt.rs:244:11
    |
244 |     #[cfg(tokio_unstable)]
    |           ^^^^^^^^^^^^^^
    |
    = help: consider using a Cargo feature instead
    = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint:
             [lints.rust]
             unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tokio_unstable)'] }
    = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tokio_unstable)");` to the top of the `build.rs`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

@LeonHartley
Copy link
Contributor Author

LeonHartley commented Aug 23, 2024

@mcches I get the same thing on main branch too.
https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values
It's a new lint

@LeonHartley
Copy link
Contributor Author

Raised #182 for the clippy failure

@mcches
Copy link
Contributor

mcches commented Aug 23, 2024

Raised #182 for the clippy failure

Thank you. I'll merge this now and sort out the clippy issue.

@mcches mcches merged commit dda269f into tokio-rs:main Aug 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants