-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade grpc example deps, fixing #180 #181
upgrade grpc example deps, fixing #180 #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
} | ||
} | ||
|
||
impl tonic::transport::server::Connected for TurmoilTcpStream { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that TokioIo
brings us pretty close to not having to implement all these traits for turmoil types, other than this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the AsyncRead
/ AsyncWrite
implementations, or implementations for hyper::rt::Read/Write
as TokioIo<T>
requires T
to impl either of those
Can you check out the clippy failure? |
@mcches doesn't look related to the changes to the gRPC example:
|
@mcches I get the same thing on |
Raised #182 for the clippy failure |
Thank you. I'll merge this now and sort out the clippy issue. |
No description provided.