Handles host bounce after crash #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue that host was removed from the sim state after host crash. With this fix, we change the way how we track state of the host during simulation. Crashed and hosts that have finished it's execution are no longer removed from simulation's state, that allowed us to bounce them. We might need to add explicit way to remove hosts from simulation in the future but there is no need to do it right now. This change also encapsulates host's state management and it's operations(e.g. crash/bounce) into Role type that allowed to simplify Sim::step function code and make task's state management code more clean.
|
I agree |
mcches
requested changes
Feb 20, 2023
I've stuck with renaming. I like current Current
|
mcches
reviewed
Feb 27, 2023
Role turn out to become mostly wrapper around Rt, so this change merges it into Rt, combining software status tracking and runtime ticks.
tereshch-aws
commented
Mar 1, 2023
tereshch-aws
commented
Mar 1, 2023
mcches
approved these changes
Mar 1, 2023
Co-authored-by: Brett McChesney <39924297+mcches@users.noreply.github.com>
th7nder
pushed a commit
to th7nder/turmoil
that referenced
this pull request
Mar 13, 2023
Hosts were made fallible in tokio-rs#67, which surfaced a bug in the sim's event loop when hosts were crashed. This fixes that issue by extracting the software result on completion and includes some refactoring to consolidate `Role` and `Rt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue that host was removed from the sim state after host crash. With this fix, we change the way how we track state of the host during simulation. Crashed and hosts that have finished it's execution are no longer removed from simulation's state, that allowed us to bounce them. We might need to add explicit way to remove hosts from simulation in the future but there is no need to do it right now.
This change also encapsulates host's state management and it's operations(e.g. crash/bounce) into Role type that allowed to simplify Sim::step function code and make task's state management code more clean.
Update: @th7nder submitted #89 in parallel, with the same approach to the fix but without refactoring. I don't mind to go with it if my refactoring is too much.
Special focus:
finished_errfunction. It feels weird to checkis_finishedand then callfinished_err()? but I was not able to come up with better way to do it.Index<addr, Option<Role>>didn't work out well. It polluted code with handling option is none and expects. After moving state into Role code become more clean.