Fix a Webmock regression #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webmock overrides a ton of the Patron session internals, and it furnishes a modified string of headers to the internal parse_headers method. That string, unlike real libCURL header strings, does not have the terminating CRLF at the end of the last header. Nor does it have an empty line at the very end ending with CRLF. This led our parser to return early since it could not find the string terminator, and the early return in the header parser code did not return the `responses` array that was already prepared for use. Even though this is not completely "clean" we will just use a simpler parsing approach without scans. That said, the expectation that Webmock will keep working with the refactors we appply - given how much private stuff they rely on - might be a little naive. Closes #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webmock overrides a ton of the Patron session internals, and it furnishes a modified
string of headers to the internal parse_headers method. That string, unlike real libCURL
header strings, does not have the terminating CRLF at the end of the last header. Nor does
it have an empty line at the very end ending with CRLF. This led our parser to return early
since it could not find the string terminator, and the early return in the header parser
code did not return the
responsesarray that was already prepared for use. Even thoughthis is not completely "clean" we will just use a simpler parsing approach without scans.
That said, the expectation that Webmock will keep working with the refactors we appply -
given how much private stuff they rely on - might be a little naive.
Closes #157