Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create zoneinfo-utils package #182

Merged
merged 38 commits into from
Jan 17, 2021
Merged

Create zoneinfo-utils package #182

merged 38 commits into from
Jan 17, 2021

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Jan 4, 2021

Fix #179

@Eeems Eeems added the packages Add or improve packages of the repository label Jan 4, 2021
@Eeems Eeems marked this pull request as ready for review January 4, 2021 05:46
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/opt/usr/bin/tzselect runs well and shows my proper time. I still need to figure out, why setting the TZ env and relogging doesn't make it permanent.

Other then tzselect and zdump not being in the path, it seems great.

package/tzdata/package Outdated Show resolved Hide resolved
@Eeems
Copy link
Member Author

Eeems commented Jan 5, 2021

/opt/usr/bin/tzselect runs well and shows my proper time. I still need to figure out, why setting the TZ env and relogging doesn't make it permanent.

Other then tzselect and zdump not being in the path, it seems great.

Have you tried timedatectl?

I guess I can open up a PR to get /opt/usr/bin added to the path. I wonder if we should just have a package for it that drops a file in /etc/profile.d

@Eeems
Copy link
Member Author

Eeems commented Jan 5, 2021

I wouldn't mind a quick test by someone with an rM2. @danshick or @raisjn?

@Eeems Eeems requested a review from LinusCDE January 5, 2021 02:11
@danshick
Copy link
Member

danshick commented Jan 5, 2021

I wouldn't mind a quick test by someone with an rM2. @danshick or @raisjn?

tzselect is working for me but zdump gives me

-sh: /opt/bin/zdump: cannot execute binary file: Exec format error

and file seems to indicate it is x86-64

reMarkable: ~/ file /opt/bin/zdump
/opt/bin/zdump: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=8cb1be21845976a1dfb7965b0e65d3e125ac680e, stripped

I cloned toltec, checked out Eeems-patch-4, manually built with make tzdata and copied the ipk to my remarkable to install with opkg. Maybe I'm doing something wrong because this should be broken for rm1 too.

@Eeems
Copy link
Member Author

Eeems commented Jan 5, 2021

I can confirm that I'm also getting this on my rM1. Very odd as to why it's a x86-64 binary instead of arm. Time to poke around in the Makefile.

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

Should be fixed now.

LinusCDE
LinusCDE previously approved these changes Jan 16, 2021
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. I didn't retest on rM 1, but seeing that the package now contains the iso3166.tab, I don't see any reason why it shouldn't work.

Tested on rM 2 (toltec/entware installed with bootstrap from #213) and it worked flawless as well.

:shipit:

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

Hmm, should we install this by default in bootstrap?

@matteodelabre
Copy link
Member

I see that this package and a few others install man pages to the device. I’m not sure we should do that since space is a bit scarce.

@matteodelabre
Copy link
Member

Hmm, should we install this by default in bootstrap?

What would be the motivations for installing it by default?

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

I see that this package and a few others install man pages to the device. I’m not sure we should do that since space is a bit scarce.

Man is available in entware, and other packages there do install manpages. Perhaps we should split them out into separate *-manpages packages?

@matteodelabre
Copy link
Member

matteodelabre commented Jan 16, 2021

Man is available in entware, and other packages there do install manpages. Perhaps we should split them out into separate *-manpages packages?

Good point. I think this can be done in a separate PR.

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

Opened #235

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

What would be the motivations for installing it by default?

I'm not sure what I was thinking before. timedatectl doesn't require these files right?

@matteodelabre
Copy link
Member

I believe it uses zone.tab which is already in zoneinfo-core. We should however install zoneinfo-core by default ideally, which is not the case currently.

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

Doesn't entware install it by default?

@matteodelabre
Copy link
Member

For some reason it installs zoneinfo-asia and zoneinfo-europe but not zoneinfo-core. (See the definition of entware-opt.)

@Eeems
Copy link
Member Author

Eeems commented Jan 16, 2021

Very odd. I'll open an issue to address it.

@Eeems Eeems requested a review from LinusCDE January 16, 2021 23:20
@LinusCDE
Copy link
Member

Retested on rM 1. Works as well.

@Eeems
Copy link
Member Author

Eeems commented Jan 17, 2021

Can I get a approval so I can merge?

@Eeems Eeems merged commit d5b9dc3 into testing Jan 17, 2021
@Eeems Eeems deleted the Eeems-patch-4 branch January 17, 2021 00:20
matteodelabre added a commit that referenced this pull request Jul 21, 2021
Important notices:

* When upgrading, users should run `opkg update && opkg upgrade` **twice** because of the changes introduced by this merge. (#310)
* Toltec **no longer supports** OS releases **earlier than 2.6**. You can check your current OS version in the settings panel. Please upgrade to 2.6 or newer after upgrading your Toltec install. (#366)
* To re-enable Toltec, **run `toltecctl reenable`** instead of the previous `entware-reenable` script that has been removed with this update.

Major change: The repository is now split into architecture subfolders. The `rmall` subfolder contains packages that can run both on reMarkable 1 and reMarkable 2 without modification. The `rm1` and `rm2` subfolders contain packages that are specific to each of the two devices. This change requires updating the Opkg configuration to point to the appropriate architectures. The migration is automated by placing an upgrade to the `toltec-bootstrap` package in the root folder of the repo that contains a migration script. (Note that this package is not generated automatically by our build system but will be added manually by the server administrator.)

New packages:

* bash-completion - 2.11-3 (#277, #375)
* display - 1.0.1-7 _(replaces the server part of the old rm2fb package)_ (#310)
* fuse - 1.0.0-2 (#331)
* gocryptfs - 2.0-beta2 (#318)
* innernet - 1.3.1-2 (#350, #358, #361)
* netsurf - 0.4.0-1 (#339)
* puzzles - 0.2.2-2 (#326)
* remarkable-stylus - 0.0.3-1 (#383)
* rm2fb-client - 1.0.1-7 _(replaces the client part of the old rm2fb package)_ (#310)
* tilem - 0.0.7-1 (#352)
* toltec-completion - 0.2.0-1 (#277)
* yaft - 0.0.4-3 (#261, #353)
* zoneinfo-utils - 2021a-2 (#182)

Updated packages:

* appmarkable - 0.0.0-11
* bufshot - 0.1.0-5
* calculator - 0.0.0-15
* chessmarkable - 0.7.1-2 (#362, #373)
* ddvk-hacks - 23.02-1 (#385)
* draft - 0.2.0-20
* evtest - 1.34-3
* fbink fbdepth fbink-doom - 1.23.1-4
* fingerterm - 1.3.5-14
* genie - 0.1.5-3
* harmony - 0.1.3-3
* iago - 0.1.0-4
* keywriter - 0.1.0-3
* koreader - 2021.06-1 (#330, #348, #357, #378)
* lamp - 0.1.0-4
* libdlib libdlib-dev - 19.21-2
* libvncserver libvncclient libvncserver-dev - 0.9.13-2
* mines - 0.1.2-4
* nao - 0.1.3-3
* oxide erode fret rot tarnish decay corrupt anxiety - 2.2-1 (#382)
* plato - 0.9.17-2 (#344)
* quickjs - 2020.11.08-2
* recrossable - 0.0.0-7
* remarkable-splash - 1.0-5
* remux - 0.1.9-3
* restream - 1.1-2
* retris - 0.6.3-3
* rmservewacominput - 0.3.0-2
* simple - 0.1.4-3
* templatectl - 0.1.3-3
* toltec-bootstrap - 0.1.0-1 _(includes toltecctl)_ (#379)
* vnsee - 0.4.0-2 (#355)
* wikipedia - 0.1.0-3
* wireguard - 1.0.20210219-2
* xochitl - 0.0.0-7 (#383, #382, #386)
* zshelf - 0.3.1-3

Website: The source files and scripts used for generating the website have been transferred to a separate repository (<https://github.com/toltec-dev/web>). A website rebuild is triggered automatically from this repository’s workflow when the stable branch is updated, so that the displayed checksum of the bootstrap script is always accurate.
matteodelabre added a commit that referenced this pull request Jul 31, 2021
Important notices:

* When upgrading, users should run `opkg update && opkg upgrade` **twice** because of the changes introduced by this merge. (#310)
* Toltec **no longer supports** OS releases **earlier than 2.6**. You can check your current OS version in the settings panel. If you’re still running on 2.5 or earlier, please upgrade to 2.6 or newer after upgrading your Toltec install. (#366)

Less important notices:

* To re-enable Toltec after a system upgrade, **run `toltecctl reenable`** instead of the previous `entware-reenable` script that has been removed with this update.
* You can now easily uninstall Toltec by running `toltec uninstall`.
* This release marks the end of our work towards transitioning to a new repository layout. This means that **stable will be updated more frequently from now on.** If you switched to the testing branch because stable has been outdated for a few months, and if you prefer to run stable releases, you can go back to the stable branch by running `toltecctl switch-branch stable`.

Layout change: The repository is now split into architecture subfolders. The `rmall` subfolder contains packages that can run both on reMarkable 1 and reMarkable 2 without modification. The `rm1` and `rm2` subfolders contain packages that are specific to each of the two devices. This change requires updating the Opkg configuration to point to the appropriate architectures. The migration is automated by placing an upgrade to the `toltec-bootstrap` package in the root folder of the repo that contains a migration script.

New packages:

* bash-completion - 2.11-3 (#277, #375)
* display - 1.0.1-7 _(replaces the server part of the old rm2fb package)_ (#310)
* fuse - 1.0.0-3 (#331)
* gocryptfs - 2.0-beta2 (#318)
* innernet-client - 1.3.1-2 (#350, #358, #361)
* netsurf - 0.4.0-2 (#339)
* puzzles - 0.2.2-3 (#326)
* remarkable-stylus - 0.0.3-1 (#383)
* rm2fb-client - 1.0.1-7 _(replaces the client part of the old rm2fb package)_ (#310)
* tilem - 0.0.7-2 (#352)
* toltec-completion - 0.2.0-1 (#277)
* yaft - 0.0.4-4 (#261, #353)
* zoneinfo-utils - 2021a-2 (#182)

Updated packages:

* appmarkable - 0.0.0-11
* bufshot - 0.1.0-5
* calculator - 0.0.0-15
* chessmarkable - 0.8.0-1 (#362, #373, #392)
* ddvk-hacks - 23.02-1 (#385)
* draft - 0.2.0-20
* evtest - 1.34-3
* fbink fbdepth fbink-doom - 1.23.2-1 (#387)
* fingerterm - 1.3.5-14
* genie - 0.1.5-3
* harmony - 0.1.3-3
* iago - 0.1.0-4
* keywriter - 0.1.0-3
* koreader - 2021.07-1 (#330, #348, #357, #378, #389)
* lamp - 0.1.0-4
* libdlib libdlib-dev - 19.21-2
* libvncserver libvncclient libvncserver-dev - 0.9.13-2
* mines - 0.1.2-4
* nao - 0.1.3-3
* oxide erode fret rot tarnish decay corrupt anxiety - 2.2.1-1 (#382)
* plato - 0.9.17-2 (#344)
* quickjs - 2020.11.08-2
* recrossable - 0.0.0-7
* remarkable-splash - 1.0-5
* remux - 0.1.9-4
* restream - 1.1-2
* retris - 0.6.3-3
* rmservewacominput - 0.3.0-2
* simple - 0.1.4-3
* templatectl - 0.1.3-3
* toltec-bootstrap - 0.1.0-1 _(includes toltecctl)_ (#379)
* vnsee - 0.4.0-2 (#355)
* wikipedia - 0.1.0-3
* wireguard - 1.0.20210219-2
* xochitl - 0.0.0-7 (#383, #382, #386)
* zshelf - 0.3.1-3

Website: The source files and scripts used for generating the website have been transferred to a separate repository (<https://github.com/toltec-dev/web>). A website rebuild is triggered automatically from this repository’s workflow when the stable branch is updated, so that the displayed checksum of the bootstrap script is always accurate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timezone info package
4 participants