Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add restream to toltec #184

Merged
merged 3 commits into from
Jan 5, 2021
Merged

Add restream to toltec #184

merged 3 commits into from
Jan 5, 2021

Conversation

danshick
Copy link
Member

@danshick danshick commented Jan 4, 2021

Adds restream helper binary to toltec. restream will need to update the script to stop assuming that this binary is in the home directory, and rely on it being in the path. Additionally, another PR (in progress) will add support for rm2fb users.

Eeems
Eeems requested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add a postinstall script that just lets the user know that they have to install the PC side for this to work. Maybe give a link as well to the repository.

package/restream/package Outdated Show resolved Hide resolved
raisjn
raisjn reviewed Jan 4, 2021
View reviewed changes
package/restream/package Outdated Show resolved Hide resolved
Eeems
Eeems previously approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on the rM1.

@danshick
Copy link
Member Author

danshick commented Jan 5, 2021

Added a conflict for rm2fb. I'll remove it and PR the change once reStream support is added.

@Eeems Eeems merged commit e6a49e1 into toltec-dev:testing Jan 5, 2021
LinusCDE
LinusCDE reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@LinusCDE LinusCDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. 👍 (Not that it matters now) xD

@LinusCDE LinusCDE mentioned this pull request Jan 6, 2021
Open
28 tasks
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Jan 13, 2021
@danshick danshick deleted the add-restream branch January 27, 2021 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisjn raisjn raisjn left review comments

@LinusCDE LinusCDE LinusCDE left review comments

@Eeems Eeems Eeems approved these changes

Assignees
No one assigned
Labels
packages Add or improve packages of the repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danshick @Eeems @LinusCDE @raisjn @matteodelabre