Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better version number error messages #314

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Provide better version number error messages #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08f4d3
Provide better version number error messages
Eeems Mar 14, 2021
33fc24f
Fix formatting
Eeems Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/toltec/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,14 @@ def __init__(self, epoch: int, upstream: str, revision: str):
self.epoch = epoch

if _VERSION_CHARS.fullmatch(upstream) is None:
raise InvalidVersionError("Invalid chars in upstream version")
raise InvalidVersionError(
f"Invalid chars in upstream version: '{upstream}'"
)

if _VERSION_CHARS.fullmatch(revision) is None:
raise InvalidVersionError("Invalid chars in revision")
raise InvalidVersionError(
f"Invalid chars in revision: '{revision}'"
)

self._original: Optional[str] = None

Expand Down