Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak off api key by loading from manifest xml #256

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

diegojimenes
Copy link

i had a little problem with play store because the key of google places was be exposed in the gradle properties, so i move it to android manifest. but i don't know if is a correct approach.

@tolu360
Copy link
Owner

tolu360 commented Jun 15, 2020

Hi @diegojimenes, I am sorry I have been away and just looking at this. I am working on releasing a v4, a week from now, at the latest. However, if you used early versions of the library, you would recall the keys have always been in the manifest files - I am not sure they were safer there and some users wanted to be able to do different things for different environments and didn't have any easy way to do so at the time. Chime in with your thoughts in the replies if you can. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants