core/types: make "miner" optional in Header JSON (#24666)

"miner" is not set for pending block responses in some cases. Fixes #24632
tolunghk · Sep 21, 2022 · f37f2a9 · f37f2a9
1 parent a41619f
commit f37f2a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/core/types/block.go b/core/types/block.go
@@ -100,7 +100,7 @@ func (n *BlockNonce) UnmarshalText(input []byte) error {
 type Header struct {
 	ParentHash  common.Hash    `json:"parentHash"       gencodec:"required"`
 	UncleHash   common.Hash    `json:"sha3Uncles"       gencodec:"required"`
-	Coinbase    common.Address `json:"miner"            gencodec:"required"`
+	Coinbase    common.Address `json:"miner"`
 	Root        common.Hash    `json:"stateRoot"        gencodec:"required"`
 	TxHash      common.Hash    `json:"transactionsRoot" gencodec:"required"`
 	ReceiptHash common.Hash    `json:"receiptsRoot"     gencodec:"required"`

diff --git a/core/types/gen_header_json.go b/core/types/gen_header_json.go