Unschedule delete after ttl #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And SessionAuthenticationMiddleware class is removed in 2.0 as it provided no functionality since session authentication is unconditionally enabled in Django 1.10.
In python2.x d.keys() returned a list. With python3.x, d.keys() returns a dict_keys object which behaves a lot more like a set than a list. As such, it can't be indexed. Changing d.keys() to list(d)) will return a list of keys on both python2.x and python3.x without making any copies. reference: https://stackoverflow.com/questions/17322668/typeerror-dict-keys-object-does-not-support-indexing
delete takes care of unscheduling admin uses model.delete instead of model.all.delete tests updated
tom-price
force-pushed
the
unschedule-delete_after_ttl
branch
from
4c3b3e3 to
12f6a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.