Skip to content

Commit

Permalink
Removed TODOs (created follow up issue helidon-io#3200)
Browse files Browse the repository at this point in the history
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
  • Loading branch information
tomas-langer committed Jul 19, 2021
1 parent c60d517 commit ce903ef
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ private void handleBadFilter(Action action, String message) {
LOGGER.warning(message);
break;
case CONFIGURE:
// TODO this will change with Java 17, where we can create a combined filter
throw new IllegalStateException("Cannot reconfigure current global deserialization filter."
+ " Original message: " + message);
case IGNORE:
Expand Down Expand Up @@ -362,9 +361,7 @@ public enum TraceOption {
* {@link SerializationConfig#configureRuntime()} directly.
*/
public static class Builder implements io.helidon.common.Builder<SerializationConfig> {
// TODO change default action to FAIL for 3.0.0
private Action onWrongConfig = configuredAction(PROP_WRONG_CONFIG_ACTION, Action.WARN);
// TODO change default action to CONFIGURE for 3.0.0
private Action onNoConfig = configuredAction(PROP_NO_CONFIG_ACTION, Action.WARN);
private String filterPattern = System.getProperty(PROP_PATTERN);
private TraceOption traceSerialization = configuredTrace(TraceOption.NONE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

class DeserializationTest {
private static final String TEST_STRING = "Hello_" + new Random().nextInt(10);
;

@BeforeAll
static void configureDeserialization() {
Expand Down

0 comments on commit ce903ef

Please sign in to comment.