refactor: Improve arguments used by the dbt hook and operators #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbt v1.0.0 deprecated some arguments that we were still exposing, so those were taken out. Some arguments were missing, like variants of mutually exclusive arguments, so they were added. Mutually exclusive arguments are now properly handling by setting the positive version (the one without the no_ prefix) since that's the one dbt CLI sets too. Test cases were updated to reflect this changes. Finally, arguments were sorted to make them easier to navigate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbt v1.0.0 deprecated some arguments that we were still exposing, so
those were taken out.
Some arguments were missing, like variants of mutually
exclusive arguments, so they were added.
Mutually exclusive arguments are now properly handling by setting the
positive version (the one without the no_ prefix) since that's the one
dbt CLI sets too.
Test cases were updated to reflect this changes.
Finally, arguments were sorted to make them easier to navigate.