Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchable menus: sometimes, no match when performing a search #637

Closed
xfzv opened this issue Sep 21, 2023 · 2 comments · Fixed by #638
Closed

searchable menus: sometimes, no match when performing a search #637

xfzv opened this issue Sep 21, 2023 · 2 comments · Fixed by #638

Comments

@xfzv
Copy link
Contributor

xfzv commented Sep 21, 2023 •
edited
Loading

I was playing around with the new searchable menus feature and have noticed that sometimes, the search doesn't match any pattern in some menus.

Occurs with either menu_type_to_search=yes or menu_type_to_search=no. Two videos showcasing the issue:

  1. Local video (no match in audio, subtitles, video and chapters menu, works in playlist menu)

  2. YouTube video (no match in chapters and playlist menu, works in audio and video menus)

Edit: Removed the videos since GitHub doesn't load them for some reasons, here's a Send link: https://send.vis.ee/download/58f018edf5d509fb/#_TqijQWGCDPRR3QcLPk5PQ
@christoph-heinrich
Copy link
Contributor

What the... I could have sworn that I made sure case insensitive search worked, but apparently the query:lower() must have gotten lost somehow. I'll quickly make PR.

christoph-heinrich added a commit to christoph-heinrich/uosc that referenced this issue Sep 21, 2023
@christoph-heinrich
fix: case insensitive menu search
19f4682 
The title was lowered, but not the query.
As a result searching for uppercase letters would never match anything.

Fixes tomasklaen#637
@christoph-heinrich christoph-heinrich mentioned this issue Sep 21, 2023
Merged
@xfzv
Copy link
Contributor Author

xfzv commented Sep 21, 2023

Can confirm #638 fixes the issue. 👍

tomasklaen pushed a commit that referenced this issue Sep 21, 2023
@christoph-heinrich
fix: case insensitive menu search (#638)
f067ea3 
The title was lowered, but not the query.
As a result searching for uppercase letters would never match anything.

Fixes #637
tam1m pushed a commit to tam1m/uosc that referenced this issue Oct 2, 2023
@christoph-heinrich @tam1m
fix: case insensitive menu search (tomasklaen#638)
2c69fbd 
The title was lowered, but not the query.
As a result searching for uppercase letters would never match anything.

Fixes tomasklaen#637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: case insensitive menu search christoph-heinrich/uosc
2 participants
@christoph-heinrich @xfzv