Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently encountered a few videos with false positives for
endings
. Turns out it's because chapters ending with e.g. 'trending' would be detected as an ending. To fix that I've now applied the same pattern for 'ending' as was already used for 'ed'.While doing that I've noticed that 'opening' and 'closing' were also the same way, so I've applied the same thing to them too, but since I've never actually noticed any problems with them, I've made it a separate commit. Also I don't know if having all three variants even makes sense for all of them.
This is a draft because I'm not sure about the change and it could certainly benefit from testing and discussion.
A collection of examples of what should and shouldn't be detected for each kind would take a lot of the guesswork out of such changes. I've prepared a table in a test file (not included here) to collect examples I encounter in the wild, let's see if that will ever become good enough to be useful.