fix: only enable/disable mouse keybinds when they change #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keybindings 'mbtn_left' and 'wheel' were enabled/disabled on every render, resulting in log files being spammed with corresponding debug messages. To avoid that only call the enable/disable function when the current decision is different to the last one.
christoph-heinrich
force-pushed
the
mouse_keybind_log_spam
branch
from
3a731b9
to
fd626c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keybindings 'mbtn_left' and 'wheel' were enabled/disabled on every render, resulting in log files being spammed with corresponding debug messages.
To avoid that only call the enable/disable function when the current decision is different to the last one.
Closes #491