Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apply margin to osd-margin-y #499

Merged
merged 5 commits into from
Apr 9, 2023
Merged

feat: apply margin to osd-margin-y #499

merged 5 commits into from
Apr 9, 2023

Commits on Apr 7, 2023

  1. feat: apply margin to osd-margin-y and osd-margin-x 

    The margins were already set for `osc-margins` and
`user-data/osc/margins`, but osd messages have their own properties
`osd-margin-x` and `osd-margin-y`.
Offsetting `osd-margin-x` and `osd-margin-y` by our margin prevents
overlap of osd messages with the GUI.
    @christoph-heinrich
    christoph-heinrich committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ff1a441 View commit details
    Browse the repository at this point in the history

  2. tweak: set top margin only for persistent top bar 

    Avoids a jumping margin when the top bar is only temporarily visible.
The margin now also respects multiple title lines (alt-title, chapter)
    @christoph-heinrich
    christoph-heinrich committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    5d15f0e View commit details
    Browse the repository at this point in the history

  3. tweak: set bottom margin only for persistent bottom elements

    @christoph-heinrich
    christoph-heinrich committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    90cb2ef View commit details
    Browse the repository at this point in the history

  4. tweak: don't trigger paused persistency from timeline dragging

    @christoph-heinrich
    christoph-heinrich committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    f4ec7d6 View commit details
    Browse the repository at this point in the history

  5. feat: add option for disabling of osd margin adjustment

    @christoph-heinrich
    christoph-heinrich committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7391d54 View commit details
    Browse the repository at this point in the history