fix: cap char byte count of UTF-8 to string length #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-heinrich
force-pushed
the
fix_invalid_utf8_bounds
branch
from
329c7d3
to
dcd2629
Compare
christoph-heinrich
changed the title
|
Can confirm this behaves the same way as vanilla osc on the full set of chapters from my original test file. |
|
Wrapping with valid utf-8 strings works as expected, I haven't tested long invalid strings. But since this only changes the length of the last char, it shouldn't make much of a difference. |
po5
added a commit
to po5/memo
that referenced
this pull request
Jul 25, 2023
Fix from uosc tomasklaen/uosc#579 Improves truncation of the extension part
tam1m
pushed a commit
to tam1m/uosc
that referenced
this pull request
Oct 2, 2023
Caps char byte count of UTF-8 to string length. Closes tomasklaen#515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capping the character byte count to the remaining string length prevents out of bounds access.
Closes #515