tweak: remove symbol order from sorting algorithm #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already using the same sorting algorithm as autoload.lua, but with the addition of a custom symbol order. However that symbol order was only applied to the first character, so when sorting absolute paths it doesn't actually make a difference. Using the exact same algorithm for autoload.lua and uosc also makes it easier to apply any future improvements from one to the other.
tam1m
pushed a commit
to tam1m/uosc
that referenced
this pull request
Oct 2, 2023
…#608) We were already using the same sorting algorithm as autoload.lua, but with the addition of a custom symbol order. However that symbol order was only applied to the first character, so when sorting absolute paths it doesn't actually make a difference. Using the exact same algorithm for autoload.lua and uosc also makes it easier to apply any future improvements from one to the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already using the same sorting algorithm as autoload.lua, but with the addition of a custom symbol order. However that symbol order was only applied to the first character, so when sorting absolute paths it doesn't actually make a difference.
Using the exact same algorithm for autoload.lua and uosc also makes it easier to apply any future improvements from one to the other.
ref. #606 (comment)