feat: redesigned menu title & search query #650
Conversation
- simpler & less cluttered design without textures - search icon - clickable icon for submittable searches - search cursor - localized placeholders - clicking empty title now does nothing instead of closing the menu
scripts/uosc/elements/Menu.lua
Outdated
| }) | ||
| end | ||
|
|
||
| -- Do nothing when user clicks title | ||
| if is_current and not cursor.on_primary_down and get_point_to_rectangle_proximity(cursor, rect) then |
There was a problem hiding this comment.
You're checking cursor.on_primary_down to not overwrite the icon event, but if some element below the menu already set an event we should still overwrite it.
And it's missing a == 0.
Also maybe clicking the title should start a search?
On the other hand having a place to click while the menu is open might be nice for focusing the window.
|
I liked the look of the texture, but the increased contrast might be good for usability... |
I've realized we are already overwriting cursor events at the top of
Noo, none would expect that to happen. When people click text, they want to select it, or reposition cursor. If we are not doing any of that, than it should do nothing.
I didn't :) I just wanted it to be distinct from active item. But I like this a lot more. There's no visual clashing of menu title and active item anymore.
Yes, I don't want borders bordering borders anymore. This is clean. Presence of icon+cursor clearly indicates this is a search input now. Doesn't look cluttered at all. Would definitely feel like it with more borders. The only thing I'm still not happy about is that the text is on the right, but I don't feel like implementing all that would be needed to align it to the left :) |
Fair enough.
It's not great, but I have no idea how we could make left alignment even work seamlessly for strings wider then the menu. Edit: I've now tested it and it's pretty nice in practice, makes the ui more cohesive 👍 |
- simpler & less cluttered design without textures - search icon - clickable icon for submittable searches - search cursor - localized placeholders - clicking empty title now does nothing instead of closing the menu
Anyone see any issues or something missing?