Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scripts to install or update uosc with a single line #691

Merged
merged 11 commits into from
Oct 12, 2023
Merged

Conversation

tomasklaen
Copy link
Owner

I haven't tested the script for Linux & macOS. If anyone could, it'd be nice :) It should install current latest stable.

I also want to figure out if we can provide a uosc/update command that people can just run from their menu and update uosc in the background.

Copy link
Contributor

@christoph-heinrich christoph-heinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test on mac, but this is required for linux.

installers/unix.sh Outdated Show resolved Hide resolved
installers/unix.sh Outdated Show resolved Hide resolved
installers/unix.sh Outdated Show resolved Hide resolved
@tomasklaen
Copy link
Owner Author

Is there no way in mpv to spawn an async subprocess that won't freeze the UI and listen to its stdout and exit events with callbacks?

@christoph-heinrich
Copy link
Contributor

There is mp.command_native_async which I use in quality-menu.

@tomasklaen
Copy link
Owner Author

tomasklaen commented Oct 12, 2023

I completely missed that 😐. I guess we are not able to listen on stdin messages, and we get the whole thing at the end? Well, better than nothing.

I'll add a self-updater in a separate commit if I manage to make it work right. I'll merge this now so hopefully someone tests it on mac, because I absolutely do not want to try virtualizing that again.

@tomasklaen tomasklaen merged commit b7529ea into main Oct 12, 2023
@christoph-heinrich
Copy link
Contributor

I think it's possible to start a process directly from lua and then treat it's stdin and stdout like a file, but I never tried that myself.

@tomasklaen
Copy link
Owner Author

I think it's possible to start a process directly from lua and then treat it's stdin and stdout like a file, but I never tried that myself.

What do you mean by this? Make the process output into a file with command > file.txt and read the file periodically?

@christoph-heinrich
Copy link
Contributor

What do you mean by this?

https://www.lua.org/manual/5.1/manual.html#pdf-io.popen

@tomasklaen
Copy link
Owner Author

Dunno why I always assume we don't have access to stuff like this in here. But I can't find any docs, or snippets on how to use it asynchronously without blocking the thread.

@tomasklaen tomasklaen deleted the installers branch November 4, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants