-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize Volume icons #699
Conversation
I already tried this once as I like the idea, but in practice, the way the icons are positioned in the font, the speaker part of the icon keeps shifting horizontally as the icon changes. And for me personally, the shifting annoyance outweighs the eye candy from dynamic icon. But if others don't mind, I'd merge this. |
Yes, the icons themselves are not aligned. I personally don't mind much about this, but let's wait for the opinions of others. |
I don't mind the speaker part shifting horizontally as far as I'm concerned. Ideally it would be static but if that's not feasible, I'm fine with it. |
I've tried that already and it didn't work. It seems like the icons are monospaced and align to the middle of their monospace width. The only way to make it align would probably be to manually shift each icon by the necessary width fraction. |
Interesting that the offset required is exactly width/16 for each stage. |
No description provided.