-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: added building, packaging, and localization scripts and tools #744
Conversation
Main feature here is the `scripts/intl` tool that allows people to quickly create or update localization files with simple: ``` scripts/intl de ``` This will parse the code for localization strings, and compare it against `de` locale, removing unused, and assigning `null` to new strings. We can also make it even easier for people by running: ``` scripts/intl all ``` after every localization string change in the codebase, which will update all existing locales so people can just browse through their ones and fill in nulls.
That's nice, but instead of having binaries in the git repo it'd better to attach them to a release. |
This is a development tool, it's not going to be in a release. It should be a script, but since this project isn't built around any runtime, we can't have a script file without requiring people to install some lua, python, or node. I wanted something people can just use with no setup barriers. I look at it as a script that needs to be compiled :) I'm not a fan of binaries in git either, but this seems to be the least friction solution. |
Question regarding Because otherwise I don't get the point. Lines 33 to 38 in 55789e1
Is there another intermediate build step involved? Maybe I'm just looking in the wrong place, but I don't see a And, as I understand it, the files in |
No actions are set up atm. Packaging tool is for me to make the release zip used by command line installers and people installing manually.
It's there.
They are not generated, they are the sources. The way I look at it is Soon there will be an intermediate built step to build some binaries that'll need to be included in the release zip. Their build destination will be in I agree it's a bit of a mess, but we're juggling a lot of different environments (go, lua, mpv) and assets (fonts, soon binaries), and this seems to be the easiest to develop with. I just simlink stuff from |
Ah, yeah,
Makes sense, good to know. |
Lines 45 to 47 in b8280b0
|
@debugzxcv 😐 thx for noticing. |
Main feature here is the
intl
tool that allows people to quickly create or update localization files with simple:This will parse the codebase for localization strings, and compare it against
de
locale, removing unused, and assigningnull
to new strings.We can also make it even easier for people by running:
after every localization string change, which will update all existing locales so people can just browse through theirs and fill in nulls.