fix: keep selected index on menu update during search #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-heinrich
force-pushed
the
fix_menu_search_update_selection
branch
2 times, most recently
from
d1a384b
to
f0c507b
Compare
christoph-heinrich
force-pushed
the
fix_menu_search_update_selection
branch
from
f0c507b
to
f080cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating items during an active search always selected the first item.
I'm not sure if I should put that if in a new loop or not.
Do you prefer those
ifs to be on a single line now or not? Not sure now after those style changes.