tweak: update scroll position when moving items like when navigating #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the selected item in the middle of the scroll position, just like when navigating.
Otherwise the scrolling behavior is inconsistent between moving and navigating, and leads to odd situations like when moving the first playlist item down it's impossible to see what's above it, which is annoying when overshooting and having to go back up a bit.
Also weirdly the selected item position in the scroll view changed when holding down the up or down button. The item moved faster then the scroll position. No idea why that happened, but with this change that's not a problem anymore.
menu_scroll.mp4