tweak: always scroll to selected index on menu open #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think there is currently a use case for this, but maybe there will be at some point and it doesn't hurt. This would enable scrolling to some item on menu open even with `mouse_nav` set, but currently any place that can open a menu with `selected_index` set doesn't have `mouse_nav` set.
christoph-heinrich
force-pushed
the
menu_open_always_scroll_to_selected
branch
from
4315d66
to
4b4ac26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there is currently a use case for this, but maybe there will be at some point and it doesn't hurt.
This would enable scrolling to some item on menu open even with
mouse_navset, but currently any place that can open a menu withselected_indexset doesn't havemouse_navset.