Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: features option to enable performance impacting non-essential features #816

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

tomasklaen
Copy link
Owner

@tomasklaen tomasklaen commented Dec 8, 2023

Replaces option text_width_estimation, which is now one of its available flags:

features=accurate_text_width

Currently available flags:

accurate_text_width
accurate_sorting

Are there better names for these? Maybe just dropping the accurate_ prefixes, since the "this an improved version of X" is kind of implied already.

…l features

Replaces option `text_width_estimation`, which is now one of its available flags:

```
features=accurate_text_width
```
@christoph-heinrich
Copy link
Contributor

christoph-heinrich commented Dec 8, 2023

features doesn't seem right for that. It's not enabling additional features, but instead provides the option for alternative better but slower implementations.

improved_variant=text_width or something like that maybe? Although "improved" is also not really correct, after all if it was a flat out improvement, it would be the default...

@hooke007
Copy link
Contributor

hooke007 commented Dec 9, 2023

hr.

@po5
Copy link
Contributor

po5 commented Dec 9, 2023

refine=text_width,sorting

@dyphire
Copy link
Contributor

dyphire commented Dec 9, 2023

improve_experimental=text_width,sorting
Using experimental descriptions implies that these are not a flat out improvement.
Maybe it can be directly named experimental.

@tomasklaen tomasklaen merged commit 0d7825a into main Dec 28, 2023
@tomasklaen tomasklaen deleted the features branch September 4, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants