menus.lua: tweaks and fixes the display of the track menu #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpv upstream commit mpv-player/mpv@ab3b174 has introduced support for BCP 47 language tags, and now track lang has uppercase and lowercase content.
dyphire
changed the title
christoph-heinrich
suggested changes
May 5, 2024
src/uosc/lib/menus.lua
Outdated
| @@ -148,10 +148,10 @@ function create_select_tracklist_type_menu_opener(menu_title, track_type, track_ | |||
| title = (track.title and track.title or t('Track %s', track.id)), | |||
| hint = table.concat(hint_values, ', '), | |||
| value = track.id, | |||
| active = track.selected, | |||
| active = track.selected and track.id == tonumber(mp.get_property(track_prop)), | |||
There was a problem hiding this comment.
I'm somewhat bothered by tonumber(mp.get_property(track_prop)) being done twice on each iteration of the loop instead of once before the loop.
Youtube videos can add a ton of subtitle tracks if not restricted to specific languages via the ytdl options, and I don't know if the difference would be noticeable (probably not tbh), but since it's easy to avoid we might as well 😄
There was a problem hiding this comment.
Change to use local variables.
There was a problem hiding this comment.
It's still doing tonumber(mp.get_property(track_prop)) on each loop iteration though.
There was a problem hiding this comment.
I see what you mean, done.
dyphire
force-pushed
the
track
branch
2 times, most recently
from
366fac3
to
0af7f61
Compare
Avoid showing the selection status of secondary subtitle in the subtitle menu at the same time
christoph-heinrich
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpv upstream commit mpv-player/mpv@ab3b174 has introduced support for BCP 47 language tags,
and now track lang has uppercase and lowercase content.
Avoid showing the selection status of secondary subtitle in the subtitle menu at the same time.
current behavior of mian:
apply changes: