Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show playlist files in the file navigation menu #927

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

christoph-heinrich
Copy link
Contributor

So far the file navigation menu would only show media files and directories, but opening playlist files via that menu is a valid use case as well.

From a quick look at demux_playlist.c and a bit of testing, those seem to be the only playlist formats mpv supports.
mpv can also open .txt files as playlists, but they need to be provided via the --playlist=<path> argument and thus don't work here.

ref. #926

So far the file navigation menu would only show media files and
directories, but opening playlist files via that menu is a valid use
case as well.

From a quick look at demux_playlist.c and a bit of testing, those seem
to be the only playlist formats mpv supports.
mpv can also open .txt files as playlists, but they need to be provided
via the --playlist=<path> argument and thus don't work here.

ref. tomasklaen#926
@tomasklaen tomasklaen merged commit 3bf774b into tomasklaen:main Jul 1, 2024
@christoph-heinrich christoph-heinrich deleted the add_playlist_types branch July 2, 2024 00:32
@hooke007
Copy link
Contributor

hooke007 commented Jul 5, 2024

Playlist should be load by loadlist command instead. And the ext name is not necessary actually.

@christoph-heinrich
Copy link
Contributor Author

Playlist should be load by loadlist command instead.

Yes that would be better.

And the ext name is not necessary actually.

I'm not sure what you mean with that. The extensions are used for filtering which files show up in the navigation menu, so of course they are necessary.

@hooke007
Copy link
Contributor

hooke007 commented Jul 5, 2024

ext name is not necessary for mpv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants