Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use primary_click for chapter indicators #932

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: use primary_click for chapter indicators #932

merged 1 commit into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. fix: use primary_click for chapter indicators 

    Listening to `primary_down`, but not listening to the `primary_up` event
leads to that `up` event getting forwarded. Listening to `primary_click`
instead avoids that problem.

Seeking chapters now happens on button up instead of button down, but
that shouldn't be a problem for anyone and makes their behavior
consistent with other clickable UI elements.

ref. tomasklaen#931
    @christoph-heinrich
    christoph-heinrich committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    af82fd6 View commit details
    Browse the repository at this point in the history