Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainbow Braces: Possible crash with References window #245

Closed
tomasr opened this issue May 28, 2018 · 1 comment
Closed

Rainbow Braces: Possible crash with References window #245

tomasr opened this issue May 28, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@tomasr
Copy link
Owner

tomasr commented May 28, 2018

Possible repro:

  • Ensure Reference Window is closed (not just hidden) when VS is started
  • Open CS project
  • Right click a function in a code file and select Find all References command

Aparent exception:

    <record>920</record>
    <time>2018/05/28 22:19:07.187</time>
    <type>Error</type>
    <source>Editor or Editor Extension</source>
    <description>System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.&#x000D;&#x000A;Parameter name: position&#x000D;&#x000A;   at Microsoft.VisualStudio.Text.SnapshotPoint..ctor(ITextSnapshot snapshot, Int32 position)&#x000D;&#x000A;   at Winterdom.Viasfora.Rainbow.RainbowProvider.UpdateBraceList(SnapshotPoint startPoint, Boolean notifyUpdate)&#x000D;&#x000A;   at Winterdom.Viasfora.Rainbow.RainbowProvider.UpdateBraceList(ITextSnapshot snapshot, INormalizedTextChangeCollection changes)&#x000D;&#x000A;   at Winterdom.Viasfora.Rainbow.RainbowProvider.BufferChanged(Object sender, TextContentChangedEventArgs e)&#x000D;&#x000A;   at Microsoft.VisualStudio.Text.Utilities.GuardedOperations.RaiseEvent[TArgs](Object sender, EventHandler`1 eventHandlers, TArgs args)&#x000D;&#x000A;--- End of stack trace from previous location where exception was thrown ---&#x000D;&#x000A;   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)</description>
  </entry>
@tomasr tomasr self-assigned this May 28, 2018
@tomasr tomasr added this to the v4.1 milestone May 28, 2018
@tomasr tomasr added the bug label May 28, 2018
@tomasr
Copy link
Owner Author

tomasr commented May 31, 2018

This was caused by the tooltips in the Reference Windows. When you moved from one line to the other, the TextView and TextBuffer gets reused, but the buffer first is reduced to an empty buffer.

tomasr added a commit that referenced this issue May 31, 2018
@tomasr tomasr closed this as completed Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant