Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayView is completely rebuilt even if props don't change #147

Closed
sergiu-paraschiv opened this issue Nov 18, 2015 · 4 comments
Closed

Comments

@sergiu-paraschiv
Copy link

I think I found the bug that causes this.
This is line 149 in OverlayViewCreator.js:
this.getOverlayView()._redraw(this.props.mapPaneName !== prevProps);

Pretty clear what the bug is. The condition is always going to be true.

sergiu-paraschiv added a commit to sergiu-paraschiv/react-google-maps that referenced this issue Nov 18, 2015
sergiu-paraschiv added a commit to sergiu-paraschiv/react-google-maps that referenced this issue Nov 18, 2015
@sergiu-paraschiv
Copy link
Author

Made a PR for this: #148

@tomchentw
Copy link
Owner

Kind of stupid, thanks for the fix and PR!

@sergiu-paraschiv
Copy link
Author

Glad to be of service :)

tomchentw added a commit that referenced this issue Nov 18, 2015
@tomchentw
Copy link
Owner

Released v4.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants