-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TypeScript definitions #363
Comments
Anyone interested? |
@tomchentw Yes. Please create definition. I am using typescript on my project, but there are no .d.ts gile for maps. Thank you. |
Should I create PR here or in https://github.com/DefinitelyTyped/DefinitelyTyped? |
@mxl you can create PR here. |
Any update on this? |
I haven't used typescript in about a year, going to defer this to someone else thats more familiar and can crank it out without reading alot of docs |
I'm almost done writing definitions and will submit PR this weekend.
|
@mxl you're awesome! |
@tomchentw Sorry, I was busy on that weekend. I will finish the work this week. |
No rush. |
@mxl no rush, but please keep us posted regarding the progress on this issue. |
also interested in this |
PR's are welcomed! |
Guys, sorry for late response. I've continued my work on definitions. See #646. |
I've almost finished definitions. You can test them by installing |
also interested |
Released v9.3.0 |
If you has an error like - Cannot find namespace 'google' or Cannot find name 'Calculator': and it's spouse to work. |
Has anyone been able to get this to work that can share an example? Using examples from the documentation I'm still met with TS errors. |
@afholderman What errors do you have? |
Given this component (imports left out to keep it shorter):
Typescript throwing the error: |
@afholderman I think that this error is about |
In addition to installing the type definitions for
And it works now! |
You shouldn't have to do that, the types should auto-discover once in the |
Anyone using Webstorm? I'm getting a warning about |
I'm on Webstorm, what steps did you take to reproduce
…On 1 Feb 2018 08:20, "stonecold123" ***@***.***> wrote:
Anyone using Webstorm? I'm getting a warning about Cannot find parent
'tsconfig.json' from /.../node_modules//index.d.ts
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADk46KIJJH8CnzcdwgeVyA1J-jTfkwDlks5tQXOkgaJpZM4KXKPA>
.
|
@AAllport
The warning disappears after "node_modules" is removed. |
are you using webpack or any bundler?
…On 1 February 2018 at 08:39, stonecold123 ***@***.***> wrote:
@AAllport <https://github.com/aallport>
I installed the type file with npm i --save @types/googlemaps
I think the problem comes from the exclude settings in tsconfig.json
{
"compileOnSave": true,
"compilerOptions": {
"module": "commonjs",
"target": "es2015"
},
"exclude": [
"node_modules",
]
}
The warning disappears after "node_modules" is removed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADk46EIHe198QMfVH5igbcZFZp2GQH7Zks5tQXhEgaJpZM4KXKPA>
.
|
Do I need webpack or a bundler to use this component? I keep getting the following error:
|
Why is this closed? |
@mxl |
@digital-nomad17 Yes, they are installed with this module. Also you need definitions for googlemaps and markerclustererplus modules:
|
@mxl Can we add notes to the github page for the typedefiniton file so people can find them? |
@digital-nomad17 Actually it's better to move definitions to separate module and make it depend on |
@mxl running |
Just an FYI for anyone having trouble importing snazzymaps styles (on typescript), make sure you are using the correct type for "stylers"
should be:
types based on:
|
Impressive type definitions! |
No description provided.
The text was updated successfully, but these errors were encountered: