feat(SearchBox): Support for Google Places API search box #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to run lint on first iteration :P fixed all issues reported though, my apologies |
| // [].map.call($0.querySelectorAll("tr>td>code"), function(it){ return it.textContent; }) | ||
| export default [ | ||
| "places_changed", | ||
| ]; |
There was a problem hiding this comment.
Added new line to the last line.
|
Hey @eyebraus , thanks for the great work! And you even used 'conventional-changelog', awesome! I've left some comments, please take a look. One thing after you're done with these comments, could you do a rebase and squash these commits into the first one? So there will be only: And that'd be really awesome! One more thing, please feel free to include your handle and this pr in the comments like this: react-google-maps/src/DirectionsRenderer.js Lines 13 to 16 in 081d03f |
|
Cleaned up and ready for merge |
|
Released v2.1.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to use this library in an app I'm building, but I noticed it didn't have support for the Places search box yet! Adding a component for it, and also adding a simple example to demonstrate usage. :)