Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Map reference error with new API key #893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sakhisheikh
Copy link

Currently react-google-maps documentation is broken due APImapProjectError. It was due to api key expiration/ qouta limitatons. I replaced previous API key with new developer key with all required API restrictions. Documentation is working now. Here are added API restrictions:

Places API |  Geolocation API |  Directions API |  Maps JavaScript API |  Distance Matrix API |  Geocoding API

@milieu
Copy link

milieu commented Aug 27, 2018

@sakhisheikh Are you volunteering to pay for the entire 🌐 world's access to @tomchentw's documentation? 😁

I don't think this PR will be accepted just because doing so would mean you'll end up footing $$$$.$$ in the next 30 days 😸 💸 💸 💸 💸💸 💸

What would be a better fix would be to create an input that people could paste their API keys into, and view this documentation at their leisure and on their own 💵.

Also yeesh all the people who 👍'd your PR without understanding the consequences to you

@sakhisheikh
Copy link
Author

@milieu First of all this is developer key with limited daily quota and we're using API key at client side. For docs level, I think this is sufficient to use non-billing API key as everyone has it's own quota. If it's quota gets exhausted on excessive usage for one person, It won't effect other users.
I really appreciate your idea to make an input field in docs for every user but most of the new users don't have knowledge regarding API access. Maybe this would turn down many new users for the sake of creating new API key. Maintainers should seriously take this issue in consideration as it is a huge blockage for users to leverage docs.

@milieu
Copy link

milieu commented Sep 10, 2018

An API key is required to use any Google Map API now since their policy change, so new users would have to figure how to get a key anyway.

This change won't work once your $300 freebie is up

@urikphytech
Copy link
Contributor

I think the solution should be removing the key parameter completely. That way the example will work, and the only difference is that they will have a "For development purposes only" watermark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants