-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize ErtelPotentialVorticity
and RichardsonNumber
to work when model.buoyancy
is not BuoyancyTracer
#190
base: main
Are you sure you want to change the base?
Conversation
ErtelPotentialVorticity
to work when model.buoyancy
is not BuoyancyTracer
ErtelPotentialVorticity
and RichardsonNumber
to work when model.buoyancy
is not BuoyancyTracer
@glwagner I'd like your opinion on something. In a few of the CI runs, I get errors like these with the Where the two numbers are small, but differently small. Generally one of them is order 1e-16 and other is 1e-30. It doesn't happen every time, but often enough that I've noticed. That's what made the last CI run fail btw. Specifically this is the test that failed this previous time: Oceanostics.jl/test/runtests.jl Lines 363 to 371 in 56f7f8f
Which compares the KE dissipation from the closure model with the total tendency. Since all that's there is the closure model and no other tendencies, they should be the same. I know that Do you have thoughts? EDIT: FYI I just restarted that run. So if things are passing now, it's because of the normal variability in these tests. |
Easy fix. I wasn't aware that the function
Oceananigans.BuoyancyFormulations.buoyancy
existed when I first coded EPV.