Repair the array copy speedup trick. Fixes #236. #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remote object needs to be an array already for __array__() to be accepted by Numpy.
|
Thanks. Sorry, it will take me a few days to process, since I have a lot to do right now. |
coldfix
reviewed
Mar 2, 2018
| @@ -148,6 +148,11 @@ def __getattribute__(self, name): | |||
| return self.__dir__() | |||
| elif name in _deleted_netref_attrs: | |||
| raise AttributeError() | |||
| elif name == "__array__": # Speedup array copy if the remote is an array | |||
| if hasattr(self, '__array__'): | |||
There was a problem hiding this comment.
Note, this line causes an infinite recursion, since hasattr is based on getattr mechanism which causes __getattribute__ to be called.
|
Hi, after more consideration I found that Best, Thomas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote object needs to be an array already for array() to be accepted by Numpy.