Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added __hash__ to _local_netref_attrs #281

Closed
wants to merge 1 commit into from
Closed

Added __hash__ to _local_netref_attrs #281

wants to merge 1 commit into from

Conversation

krey
Copy link

@krey krey commented Jun 28, 2018

Fixes #280

I don't understand all the details, the issue is that the __hash__ attribute is treated as consts.HANDLE_CALLATTR instead of consts.HANDLE_HASH

@coldfix
Copy link
Contributor

coldfix commented Jun 28, 2018

Hi,

thanks!

There was previously a PR that removed __hash__ from _local_netref_attrs, see #268, fixing #267.

Can you check whether #267 is still fixed with your changes in place and add corresponding tests for both your issue and the one in #267?

Best, Thomas

@coldfix coldfix closed this in ab548e3 Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krey @coldfix