Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document corrections #353

Closed
wants to merge 1 commit into from
Closed

Document corrections #353

wants to merge 1 commit into from

Conversation

darkdrgn2k
Copy link
Contributor

Corrected document errors

@darkdrgn2k
Copy link
Contributor Author

This issue affects master as well

  • Change without releasing
  • release v4.2
  • do nothing

@dasanchez dasanchez mentioned this pull request Mar 15, 2019
Closed
@makew0rld
Copy link
Contributor

Hmm, I thought I fixed this when I made MODULES.md. Apparently not, or maybe it got reverted. Thanks for fixing it either way.

As for how to merge, I would change it in master without releasing. Broken links are bad, but don't merit a full blown release either.

@darkdrgn2k darkdrgn2k changed the base branch from develop to master March 23, 2019 02:42
@darkdrgn2k darkdrgn2k mentioned this pull request Mar 23, 2019
Merged
@darkdrgn2k darkdrgn2k changed the base branch from master to develop March 23, 2019 02:45
@darkdrgn2k
Copy link
Contributor Author

Synced from master instead

@darkdrgn2k darkdrgn2k closed this Mar 23, 2019
@darkdrgn2k darkdrgn2k deleted the docs-faqfix branch March 23, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makew0rld makew0rld makew0rld approved these changes

@benhylau benhylau Awaiting requested review from benhylau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdrgn2k @makew0rld