Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2019-03-04-prototype-release-v4.md #248

Merged
merged 4 commits into from
Mar 14, 2019
Merged

Conversation

darkdrgn2k
Copy link
Contributor

No description provided.

@@ -0,0 +1,5 @@
---
title: Prototype Release v4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.4?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to v0.4

Copy link
Member

@benhylau benhylau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we mention key features like Profiles and Yggdrasil instead of the more generic "new modules, features, and bug fixes"?

@benhylau
Copy link
Member

benhylau commented Mar 5, 2019

To someone looking at our website, I think features like Configuration Profiles and Status Web Page would be relatable?

@dasanchez
Copy link
Contributor

@darkdrgn2k @Shrinks99 @garrying @benhylau
The readme for prototype-cjdns-pi has a broken link on "Frequently Asked Questions".

When it gets embedded in tomesh.net, this readme gets funny:

  • The MODULES.md link breaks
  • The Hardware Table loses its formatting
    I'm inclined to remove the page from the website and link directly to the GitHub page straight from the 'Build a Node' option.

Thoughts?

@makew0rld
Copy link

@dasanchez

The MODULES.md link breaks

That was me. The link is [MODULES.md](./docs/MODULES.md), as before links on the README were branch dependent, linking to something like https://github.com/tomeshnet/prototype-cjdns-pi/blob/master/docs/MODULES.md . That way on the develop branch it still links to the develop version of the file. I never thought about how it would affect embedding. Should it and other similar links be changed?

@dasanchez
Copy link
Contributor

@makeworld-the-better-one
I created an issue in the prototype-cjdns-pi repo to address the broken links in the README file. It might be something as silly as losing the dot before the docs folder, but it's not a deal breaker for the purposes of this pull request.

@dasanchez dasanchez merged commit 3c6a3a1 into master Mar 14, 2019
@dasanchez dasanchez deleted the timeline-releasev4 branch March 18, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants