Skip to content

Commit

Permalink
utils.cpp: Remove duplicately defined function
Browse files Browse the repository at this point in the history
this was an ODR violation: the same function was defined twice, once
with `inline` specifier in utils.h, and once without `inline` in
utils.cpp

it happened to work on clang and gcc and msvc, most of the time, but
broke in the conda build on Windows

Signed-off-by: Tom Jakubowski <tom@prospective.dev>
  • Loading branch information
tomjakubowski committed Nov 5, 2024
1 parent a8d6c14 commit 5b5f9ce
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions cpp/perspective/src/cpp/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ parse_all_date_time(
);
}

bool
parse_all_date_time(std::tm& tm, std::string_view date_time_str) {
std::chrono::system_clock::time_point tp;
return parse_all_date_time(tm, tp, date_time_str);
}

bool
parse_all_date_time(
std::chrono::system_clock::time_point& tp, std::string_view date_time_str
Expand Down

0 comments on commit 5b5f9ce

Please sign in to comment.