Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlogo #909

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Newlogo #909

wants to merge 8 commits into from

Conversation

1984logo
Copy link

I put the new TOML logos, marks and icons in this PR. Let me know if it works for you.

@eksortso
Copy link
Contributor

We have been discussing these new logos for a long time. Can we get a blessing to make them a part of the TOML project? @pradyunsg @mojombo

@ChristianSi ChristianSi mentioned this pull request Oct 28, 2022
@eksortso eksortso mentioned this pull request Nov 20, 2022
Copy link
Contributor

@eksortso eksortso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @1984logo you intended to say "config files for humans" with an "s"?
EDIT: Ignore this one. But look at the next one.

Copy link
Contributor

@eksortso eksortso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to correct a misspelling.

logos/README.md Outdated Show resolved Hide resolved
1984logo and others added 2 commits November 21, 2022 01:18
Co-authored-by: Dave Ostroske <eksortso@users.noreply.github.com>
@septatrix
Copy link

Adding only the original vector files should be more than sufficient. Everyone should be able to convert it to the size they need and it prevents committing binary files to a repo (and also ensure there is a single source of truth).


The tagline "config files for humans" is intended to be use in conjuction with
the logo on headers, footers, or any other place where the logo can be displayed
in large format (to preserve the lisibility of the tagline).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

@septatrix
Copy link

Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others.

@1984logo
Copy link
Author

@septatrix

Adding only the original vector files should be more than sufficient.

Having raster versions of the logo in the repository is a common practice. It helps the quick adoption of the logo in most use cases.

Also some of these icons like logos/monochrome/toml-mark-black-L.png seem to have an improper viewbox showing padding on some sides but not the others.

You're right. Thank you for noticing. Let me fix that.

Copy link

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos:


The color versions are intended for a white background, while the reverse
versions are intended for a black background. The fallback versions were
designed for when the background cannot be controlled, such as in Github
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
designed for when the background cannot be controlled, such as in Github
designed for when the background cannot be controlled, such as in GitHub

The color versions are intended for a white background, while the reverse
versions are intended for a black background. The fallback versions were
designed for when the background cannot be controlled, such as in Github
`readme.md` files where the background depends on the user's dark or light theme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`readme.md` files where the background depends on the user's dark or light theme
`README.md` files where the background depends on the user's dark or light theme


## Icons

The icons are indented to be used as favicon.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The icons are indented to be used as favicon.
The icons are intended to be used as favicons.


## Tagline

The tagline "config files for humans" is intended to be use in conjuction with
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The tagline "config files for humans" is intended to be use in conjuction with
The tagline "config files for humans" is intended to be used in conjuction with


The tagline "config files for humans" is intended to be use in conjuction with
the logo on headers, footers, or any other place where the logo can be displayed
in large format (to preserve the lisibility of the tagline).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in large format (to preserve the lisibility of the tagline).
in large format (to preserve the visibility of the tagline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants