Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edit): Allow creating Tables from Items #786

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(edit): Allow creating Tables from Items #786

merged 2 commits into from
Sep 17, 2024

Conversation

epage
Copy link
Member

@epage epage commented Sep 17, 2024

As From<_> for Item forwards to From<_> for Value, this shouldn't be
a breaking change.

Fixes #785

@epage
feat(edit): Allow more From's for Item
fe18d4e
@epage
fix(edit): Allow creating Tables from Items
f8e909c 
As `From<_> for Item` forwards to `From<_> for Value`, this shouldn't be
a breaking change.

Fixes toml-rs#785
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10893944342

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 67.848%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/toml_edit/src/item.rs 2 4 50.0%
Totals Coverage Status
Change from base Build 10687699860: 0.005%
Covered Lines: 3714
Relevant Lines: 5474
💛 - Coveralls

@epage epage merged commit 8911cb1 into toml-rs:main Sep 17, 2024
15 checks passed
@epage epage deleted the table branch September 17, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toml_edit cannot collect an iterator over (key, item) pairs into Table
2 participants
@epage @coveralls