-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Show/String reform #4
Conversation
Does it really not? rust-lang/rust#21457 says:
|
Yes, that is the reason it does not - fn main() {
let res: Result<String, ()> = Err(());
res.unwrap();
} error:
|
Oh, I see. For what it’s worth, there is some discussion in rust-lang/rfcs#565 on reverting that change. |
Seems like it will be reverted. Good to know! I think my first commit is still necessary though. Would you like me to submit another PR? |
No need. I’m in the middle of building Rust, since these changes are apparently not in Nightly yet. |
Alright, I’ve published v0.2.17 with your first commit. Tests are failing, but I expect this will be resolved when the |
Oops, sorry, I got confused with rust-url. |
The proposed changes in this PR were merged with 97087a8 and published in version 0.2.4 |
Fallout from the landing on rust-lang/rust#21457