-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lockable Jetton Wallet #121
Open
KuznetsovNikita
wants to merge
3
commits into
ton-blockchain:master
Choose a base branch
from
KuznetsovNikita:feature/lockable-jetton-wallet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
- **TEP**: [0](https://github.com/ton-blockchain/TEPs/pull/0) *(don't change)* | ||
- **title**: Lockable Jetton Wallet | ||
- **status**: Draft | ||
- **type**: Contract Interface | ||
- **authors**: [KuznetsovNikita](https://github.com/KuznetsovNikita) | ||
- **created**: 13.04.2023 | ||
- **replaces**: - | ||
- **replaced by**: - | ||
|
||
# Summary | ||
|
||
This proposal suggests extending the Jetton Wallet by adding the option `get_locked_balance` get method. | ||
|
||
# Motivation | ||
|
||
New contracts have may want to disable jetton transfer until a time in the future. For this case, the Jetton Wallet should show zero balance to not affect old services and add a new get method to allow to get a locked balance and expiration date. | ||
|
||
The standard may use for: | ||
1. Jetton DAO contract may want to disable jetton transfer until voting is in progress. | ||
2. Jetton Vesting contract may want to release tokens in the future. | ||
|
||
|
||
# Guide | ||
|
||
Upon calling `get_locked_balance` get method Jetton Wallet should respond with integer jetton balance, integer jetton locked balance, and expiration date in integer UNIX epoch seconds format. | ||
|
||
# Specification | ||
|
||
## Jetton Wallet contracts | ||
An example of the implementation jetton wallet code can be found [here](https://github.com/OpenProduct/jetton-dao-contracts/blob/ece785f82e07a7833194992cfc0e2fa1a690b524/contracts/jetton_wallet.func#L367) | ||
|
||
|
||
Jetton Wallet should implement the get method: | ||
|
||
``` | ||
(int, int, int) get_locked_balance() method_id { | ||
(int balance, slice owner_address, | ||
slice jetton_master_address, cell jetton_wallet_code, | ||
int locked, int lock_expiration, | ||
cell vote_keeper_code) = load_data(); | ||
return (balance, locked, lock_expiration); | ||
} | ||
``` | ||
|
||
# Drawbacks | ||
|
||
The standard implies single expiration date single locked balance. | ||
|
||
# Rationale and alternatives | ||
|
||
This design allows us to show balance and locked balance in a user-friendly and clear format in blockchain explorers and wallets. | ||
|
||
# Prior art | ||
|
||
- | ||
|
||
# Unresolved questions | ||
|
||
- | ||
|
||
# Future possibilities | ||
|
||
- |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
Sorry, something went wrong.