Add slice_data_equal? to stdlib.fc #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SpyCheese <mikle98@yandex.ru>
…e-update Isolated outbound message queue update
…eue-update Isolated queue update
…on-blockchain#691) Co-authored-by: SpyCheese <mikle98@yandex.ru>
…sus_config limits in collator (ton-blockchain#692) Co-authored-by: SpyCheese <mikle98@yandex.ru>
…date_improvement Isolated validate improvement: higher auto validation limits and account for processed external messages when building block
Merge developer branch
Merge developer branch
Update OpenSSL library in Windows build
Update libmicrohttp in Windows build
The stdlib already has the functions `slice_empty?`, `slice_data_empty?` and `slice_refs_empty?` corresponding to "SEMPTY", "SDEMPTY" and "SREMPTY" assembly instructions. It's clear that the function name corresponding to assembly instruction 'SDEQ' should be `slice_data_equal?`, not `equal_slice_bits`, in order to maintain consistent naming conventions. Unfortunately, the mistake of calling the function `equal_slice_bits` has already been made, but at least it is possible to add the correct name as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdlib already has the functions
slice_empty?,slice_data_empty?andslice_refs_empty?corresponding to "SEMPTY", "SDEMPTY" and "SREMPTY" assembly instructions.It's clear that the function name corresponding to assembly instruction 'SDEQ' should be
slice_data_equal?, notequal_slice_bits, in order to maintain consistent naming conventions. Unfortunately, the mistake of calling the functionequal_slice_bitshas already been made, but at least it is possible to add the correct name as well.